Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(store): fix end offset of fetch result #725

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

ShadowySpirits
Copy link
Contributor

No description provided.

Signed-off-by: SSpirits <admin@lv5.moe>
Copy link
Contributor

@lizhanhui lizhanhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lizhanhui lizhanhui enabled auto-merge (squash) November 24, 2023 08:32
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #725 (4f60039) into main (e7f310d) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #725      +/-   ##
============================================
- Coverage     57.47%   57.42%   -0.06%     
+ Complexity     1224     1220       -4     
============================================
  Files           131      131              
  Lines          8029     8031       +2     
  Branches        736      736              
============================================
- Hits           4615     4612       -3     
- Misses         3019     3020       +1     
- Partials        395      399       +4     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.88% <ø> (ø)
RocketMQ Proxy 42.62% <ø> (-0.13%) ⬇️
RocketMQ Store 76.96% <100.00%> (-0.13%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.29% <ø> (ø)
Files Coverage Δ
.../automq/rocketmq/store/queue/StreamLogicQueue.java 76.76% <100.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

@lizhanhui lizhanhui merged commit e6c2bba into main Nov 26, 2023
@lizhanhui lizhanhui deleted the fix_fetch_result branch November 26, 2023 17:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants