Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

perf(s3stream/storage): remove the single main write thread #728

Merged
merged 3 commits into from
Nov 25, 2023
Merged

perf(s3stream/storage): remove the single main write thread #728

merged 3 commits into from
Nov 25, 2023

Conversation

Chillax-0v0
Copy link
Contributor

fix #715

@Chillax-0v0
feat(s3storage): timer on append callback
1a3b4fa 
Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0
fix(s3stream/cache): LogCacheBlock#size long -> AtomicLong
003b022 
Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0
perf(s3storage): make WALCallbackSequencer thread safe and remove t…
883ea23 
…he main write thread

Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0 Chillax-0v0 added enhancement New feature or request s3stream labels Nov 24, 2023
@Chillax-0v0 Chillax-0v0 requested a review from superhx November 24, 2023 13:28
@Chillax-0v0 Chillax-0v0 self-assigned this Nov 24, 2023
@Chillax-0v0 Chillax-0v0 mentioned this pull request Nov 24, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 24, 2023 •
edited
Loading

Codecov Report

Merging #728 (883ea23) into main (670b671) will decrease coverage by 0.12%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #728      +/-   ##
============================================
- Coverage     57.54%   57.42%   -0.12%     
- Complexity     1220     1221       +1     
============================================
  Files           131      131              
  Lines          8003     8029      +26     
  Branches        736      736              
============================================
+ Hits           4605     4611       +6     
- Misses         2999     3020      +21     
+ Partials        399      398       -1
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.88% <ø> (-0.26%) ⬇️
RocketMQ Proxy 42.62% <ø> (ø)
RocketMQ Store 76.98% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.29% <ø> (ø)

see 6 files with indirect coverage changes

@Chillax-0v0 Chillax-0v0 merged commit fba58e9 into main Nov 25, 2023
@Chillax-0v0 Chillax-0v0 deleted the perf-s3storage-queue-blocking branch November 25, 2023 10:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@superhx superhx

Assignees

@Chillax-0v0 Chillax-0v0

Labels
enhancement New feature or request s3stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Append callback stalling due to slow execution in the main write executor of S3 storage
2 participants
@Chillax-0v0 @superhx