Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: unify controller error handling while forwarding requests to leader node #758

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

lizhanhui
Copy link
Contributor

fix #754

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #758 (6295a3a) into main (48897c5) will increase coverage by 0.14%.
Report is 1 commits behind head on main.
The diff coverage is 56.09%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #758      +/-   ##
============================================
+ Coverage     57.36%   57.51%   +0.14%     
+ Complexity     1224     1221       -3     
============================================
  Files           131      131              
  Lines          8047     8042       -5     
  Branches        736      740       +4     
============================================
+ Hits           4616     4625       +9     
+ Misses         3035     3017      -18     
- Partials        396      400       +4     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 55.13% <56.09%> (+0.53%) ⬆️
RocketMQ Proxy 42.62% <ø> (-0.13%) ⬇️
RocketMQ Store 76.96% <ø> (-0.05%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)
Files Coverage Δ
...tmq/controller/server/store/impl/GroupManager.java 68.51% <0.00%> (+2.44%) ⬆️
...mq/controller/server/store/impl/StreamManager.java 67.58% <42.85%> (+3.84%) ⬆️
...cketmq/controller/client/GrpcControllerClient.java 58.57% <65.38%> (-0.11%) ⬇️

... and 2 files with indirect coverage changes

@ShadowySpirits ShadowySpirits merged commit 3954f7a into main Nov 29, 2023
@ShadowySpirits ShadowySpirits deleted the unify_controller_error_handling branch November 29, 2023 02:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine and unify controller request forward error handling
2 participants