Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(s3stream): reuse attributes to reduce cost during recording metrics #869

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Dec 29, 2023

No description provided.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db33289) 55.09% compared to head (41bf200) 54.98%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #869      +/-   ##
============================================
- Coverage     55.09%   54.98%   -0.11%     
  Complexity     1244     1244              
============================================
  Files           133      133              
  Lines          8535     8535              
  Branches        789      789              
============================================
- Hits           4702     4693       -9     
- Misses         3417     3426       +9     
  Partials        416      416              
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.18% <ø> (-0.51%) ⬇️
RocketMQ Store 73.61% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

@superhx superhx merged commit 607bc2b into main Dec 29, 2023
7 checks passed
@superhx superhx deleted the attributes branch December 29, 2023 07:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants