Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf(s3stream): use read lock rather than write lock in append #886

Merged
merged 5 commits into from
Jan 8, 2024

revert: no need to lock in `S3Storage`

5e1d4ae
Select commit
Loading
Failed to load commit list.
Merged

perf(s3stream): use read lock rather than write lock in append #886

revert: no need to lock in `S3Storage`
5e1d4ae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 6, 2024 in 0s

55.03% (+0.02%) compared to 1dab15a

View this Pull Request on Codecov

55.03% (+0.02%) compared to 1dab15a

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dab15a) 55.01% compared to head (5e1d4ae) 55.03%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #886      +/-   ##
============================================
+ Coverage     55.01%   55.03%   +0.02%     
  Complexity     1247     1247              
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4695     4697       +2     
+ Misses         3425     3424       -1     
+ Partials        414      413       -1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (ø)
RocketMQ Store 73.74% <ø> (+0.09%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 1 file with indirect coverage changes