Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(s3stream): prevent commit object 0 when compacting single object #953

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Mar 4, 2024

No description provided.

@SCNieh SCNieh requested a review from superhx March 4, 2024 03:50
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.94%. Comparing base (336fe9e) to head (19fce90).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #953      +/-   ##
============================================
+ Coverage     55.90%   55.94%   +0.03%     
- Complexity     1264     1267       +3     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4771     4774       +3     
  Misses         3327     3327              
+ Partials        436      433       -3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (+0.10%) ⬆️
RocketMQ Store 73.65% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

Signed-off-by: Shichao Nie <niesc@automq.com>
@superhx superhx merged commit 2b82088 into main Mar 4, 2024
8 checks passed
@superhx superhx deleted the compaction branch March 4, 2024 04:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants