Fix the function naming consistency issue: dynamic
vs dynamics
#43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
I've noticed the naming of the dynamics functions are inconsistent from file to file. For example,
dynamic()
inbase_agent.py
,Verse-library/verse/agents/base_agent.py
Lines 63 to 65 in 07dcc24
vs
dynamics()
inexample_agent/ball_agent.py
:Verse-library/verse/agents/example_agent/ball_agent.py
Lines 26 to 33 in 07dcc24
This also applies to a number of multi-dynamics agents:
Verse-library/demo/dryvr_demo/lin_thermo.py
Lines 33 to 43 in 07dcc24
Changes and tests
Since "dynamics" seem to be the more appropriate term, I've changed all references of
dynamic
that I could find todynamics
, including multi-dyanmics agents (i.e.,dynamic_heat
->dynamics_heat
. I rantests/test_verse.py
and it passed without issues.Happy to discuss further in case I missed anything :)