Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: break words on hyphens for the an_a lint #168

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

alex-ozdemir
Copy link
Contributor

The sentence "This is not an ML-based system." is grammatical, because the an/a vowel rule applies to "ML" (an initialism).

Another approach would be to add a new document iterator (similar to iter_words) that splits on hyphens too, and use that iterator.

The sentence "This is not an ML-based system." is grammatical, because
the an/a vowel rule applies to "ML" (an initialism).
@elijah-potter
Copy link
Collaborator

Looks great! Thanks for fixing it up.

@elijah-potter elijah-potter merged commit 4b7bedc into Automattic:master Sep 17, 2024
7 checks passed
@alex-ozdemir alex-ozdemir deleted the an_a_hyphen branch September 17, 2024 18:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants