fix(types): smarter casting for buffer with number (Fix #3764)

Automattic · Jan 15, 2016 · 8066b14 · 8066b14
1 parent 823d43a
commit 8066b14
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/schema/buffer.js b/lib/schema/buffer.js
@@ -125,6 +125,9 @@ SchemaBuffer.prototype.cast = function(value, doc, init) {
 
   var type = typeof value;
   if ('string' == type || 'number' == type || Array.isArray(value)) {
+    if (type === 'number') {
+      value = [value];
+    }
     ret = new MongooseBuffer(value, [this.path, doc]);
     return ret;
   }

diff --git a/test/types.buffer.test.js b/test/types.buffer.test.js
@@ -450,5 +450,14 @@ describe('types.buffer', function() {
         });
       });
     });
+
+    it('cast from number (gh-3764)', function(done) {
+      var schema = new Schema({ buf: Buffer });
+      var MyModel = mongoose.model('gh3764', schema);
+
+      var doc = new MyModel({ buf: 9001 });
+      assert.equal(doc.buf.length, 1);
+      done();
+    });
   });
 });