types: allow defining document array using [{ prop: String }] syntax

[vkarpov15]

Fix #13424

Summary

In #13424 we noticed that Mongoose doesn't infer { type: [{ name: String }] } as a documentarray, whereas { type: [new Schema({ name: String })] } does. This PR fixes that by explicitly looking through the inferred type of the array in the schema and checking against possible definitions like type: [String] and type: [Schema.Types.ObjectId].

Examples

[hasezoey]

Looks good to me, with some questions

[imranbarbhuiya]

Hi @vkarpov15 , today I was updating mongoose and found all the prop values of the schema types became unknown so I tried to check previous versions and found it's starting from 8.0.2, after checking commits and reverting them, and found this commit it causing the issue. It happens when the array of object has a type as a prop, and also if the schema has a prop with value SchemaTypes.Array

Here's my schema

export const UserSchema = new Schema(
    {
        reminders: {
            type: [
                {
                    type: { type: SchemaTypes.String },
                    date: { type: SchemaTypes.Date },
                    toggle: { type: SchemaTypes.Boolean },
                    notified: { type: SchemaTypes.Boolean },
                },
            ],
            default: [
                { type: 'vote', date: new Date(), toggle: false, notified: false },
                { type: 'daily', date: new Date(), toggle: false, notified: false },
                { type: 'drop', date: new Date(), toggle: false, notified: false },
                { type: 'claim', date: new Date(), toggle: false, notified: false },
                { type: 'work', date: new Date(), toggle: false, notified: false },
            ],
        },
        avatar: {
            type: SchemaTypes.String,
        },
    },
    { timestamps: true },
);

export type IUser = InferSchemaType<typeof UserSchema>;

Lemme know if I'm doing anything wrong with the schema. Or if it's a bug, I'll be happy to contribute, lemme me know how can I fix it.

If you want me to create a separate issue instead of this comment then also lemme know and I'll create a separate issue. Thanks

[hasezoey]

@imranbarbhuiya

If you want me to create a separate issue instead of this comment then also lemme know and I'll create a separate issue. Thanks

seeing as there has not been a reply and this not being the best place to report this, consider opening a new issue referencing this PR, if this is the problem