Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docs(model): remove callback example for ensureIndexes() #14252

Merged
merged 1 commit into from
Jan 12, 2024
Merged

docs(model): remove callback example for ensureIndexes() #14252

merged 1 commit into from
Jan 12, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14238

Summary

Fixed an out of date example that still uses callbacks; we dropped support for callbacks in Mongoose 7.

Examples

@vkarpov15 vkarpov15 added this to the 8.0.5 milestone Jan 11, 2024
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@vkarpov15 vkarpov15 merged commit 9ed507a into master Jan 12, 2024
34 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14238 branch January 12, 2024 14:40
@vkarpov15 vkarpov15 modified the milestones: 8.0.5, 8.1 Jan 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@hasezoey hasezoey Awaiting requested review from hasezoey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.

passing an error handler function in ensureIndexes results in a TypeError
2 participants
@vkarpov15 @AbdelrahmanHafez