Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

types(schema): re-export the defintion for SearchIndexDescription #14464

Merged

Conversation

noseworthy
Copy link
Contributor

Summary

I'm trying to add support for creating search indices to typegoose here: typegoose/typegoose#921

Since typegoose doesn't depend on or import mongodb I've had to create a copy of the SearchIndexDescription type from mongodb that is going to become out of date if the type in mongodb changes. I thought it'd be better if mongoose could re-export the type so that typegoose, mongoose, and mongodb can all be in sync.

Examples

N/A

Make a `mongoose` copy of `SearchIndexDescription` from `mongodb` and
re-export it for use in `typegoose`.
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 8.2.4 milestone Mar 26, 2024
@vkarpov15 vkarpov15 merged commit f3a094f into Automattic:master Mar 26, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants