Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: depopulate if push() or addToSet() with an ObjectId on a populated array #14883

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: depopulate if push() or addToSet() with an ObjectId on a populated array #14883

merged 2 commits into from
Sep 11, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #1635

Summary

Calling push() on a populated array with an ObjectId currently casts the ObjectId to a document, which seems like dubious behavior. This PR changes that behavior. Putting this in the 8.7 milestone for caution.

Examples

@vkarpov15 vkarpov15 added this to the 8.7 milestone Sep 10, 2024
hasezoey
hasezoey reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is it already documented that pushing a raw id type to a populated array will depopulate it?

@vkarpov15
Copy link
Collaborator Author

@hasezoey I added that in edc7dde

@vkarpov15 vkarpov15 merged commit 41aebad into 8.7 Sep 11, 2024
26 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-1635-2 branch September 12, 2024 08:53
@nejidevelops nejidevelops mentioned this pull request Oct 20, 2024
Open
@ShivamNimje6 ShivamNimje6 mentioned this pull request Oct 20, 2024
Open
@zntb zntb mentioned this pull request Oct 21, 2024
Merged
@nejidevelops nejidevelops mentioned this pull request Oct 22, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 23, 2024
Open
@sharma731 sharma731 mentioned this pull request Oct 23, 2024
Open
@axqqt axqqt mentioned this pull request Oct 23, 2024
Open
@zntb zntb mentioned this pull request Oct 24, 2024
Merged
@Tobsukka Tobsukka mentioned this pull request Oct 25, 2024
Open
@ranjith221132 ranjith221132 mentioned this pull request Oct 25, 2024
Open
@k2xl k2xl mentioned this pull request Oct 25, 2024
Closed
@hamzabetbaieb hamzabetbaieb mentioned this pull request Oct 25, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Oct 25, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Oct 25, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Oct 26, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Oct 26, 2024
Merged
@Gabo-Tech Gabo-Tech mentioned this pull request Oct 27, 2024
Open
@axqqt axqqt mentioned this pull request Oct 27, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Oct 28, 2024
Open
@Manojgupta103 Manojgupta103 mentioned this pull request Oct 28, 2024
Merged
@xeni09 xeni09 mentioned this pull request Oct 28, 2024
Open
@zntb zntb mentioned this pull request Nov 5, 2024
Merged
@KovacevicAleksa KovacevicAleksa mentioned this pull request Nov 5, 2024
Merged
@saileshbro saileshbro mentioned this pull request Nov 5, 2024
Merged
@JasperVanNiekerk JasperVanNiekerk mentioned this pull request Nov 5, 2024
Merged
@MSK-009 MSK-009 mentioned this pull request Nov 5, 2024
Open
@zntb zntb mentioned this pull request Nov 6, 2024
Merged
@pradumchintamani pradumchintamani mentioned this pull request Nov 6, 2024
Open
@aditya-arcot aditya-arcot mentioned this pull request Nov 6, 2024
Merged
@NotZarifGithub NotZarifGithub mentioned this pull request Nov 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Nov 6, 2024
Open
@lholmquist lholmquist mentioned this pull request Nov 6, 2024
Merged
@issam-seghir issam-seghir mentioned this pull request Nov 6, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 7, 2024
Merged
@Tobsukka Tobsukka mentioned this pull request Nov 8, 2024
Open
@k2xl k2xl mentioned this pull request Nov 8, 2024
Closed
@MihikaNigam MihikaNigam mentioned this pull request Nov 8, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Nov 8, 2024
Open
@AntenehTsegayeTessema AntenehTsegayeTessema mentioned this pull request Nov 8, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Nov 9, 2024
Open
@zntb zntb mentioned this pull request Nov 9, 2024
Closed
@aviraj1703 aviraj1703 mentioned this pull request Nov 9, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 9, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 10, 2024
Open
@axqqt axqqt mentioned this pull request Nov 10, 2024
Open
@AndrewTroll AndrewTroll mentioned this pull request Nov 11, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Nov 11, 2024
Open
@axqqt axqqt mentioned this pull request Nov 11, 2024
Open
@sachinthapa572 sachinthapa572 mentioned this pull request Nov 11, 2024
Open
@ST10029788 ST10029788 mentioned this pull request Nov 12, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Nov 13, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hasezoey hasezoey hasezoey left review comments

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.7
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarpov15 @hasezoey