Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: handle buffers stored in MongoDB as EJSON representation with { $binary } #14932

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: handle buffers stored in MongoDB as EJSON representation with { $binary } #14932

merged 1 commit into from
Oct 7, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14911

Summary

#14911 is caused by some edge case that caused buffers to be saved in MongoDB as { $binary: 'base64str' } EJSON representation. In older versions of Mongoose, Mongoose buffers correctly handled that format, so I'm adding explicit support for that format with tests for compatibility.

Examples

@vkarpov15 vkarpov15 added this to the 8.6.5 milestone Oct 2, 2024
@vkarpov15 vkarpov15 merged commit 048eebc into master Oct 7, 2024
46 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14911 branch October 9, 2024 09:30
@axqqt axqqt mentioned this pull request Oct 31, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Oct 31, 2024
Open
@zntb zntb mentioned this pull request Oct 31, 2024
Merged
@MattPlayGamez MattPlayGamez mentioned this pull request Oct 31, 2024
Merged
@Niaz-estefaie Niaz-estefaie mentioned this pull request Oct 31, 2024
Open
@SukritDeb SukritDeb mentioned this pull request Oct 31, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Oct 31, 2024
Open
@Tobsukka Tobsukka mentioned this pull request Nov 1, 2024
Open
@k2xl k2xl mentioned this pull request Nov 1, 2024
Closed
@MihikaNigam MihikaNigam mentioned this pull request Nov 1, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Nov 1, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Nov 1, 2024
Merged
This was referenced Nov 2, 2024
Merged
Closed
@1995preethi 1995preethi mentioned this pull request Nov 2, 2024
Open
@saiteja-madha saiteja-madha mentioned this pull request Nov 2, 2024
Closed
@aviraj1703 aviraj1703 mentioned this pull request Nov 2, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 2, 2024
Open
@axqqt axqqt mentioned this pull request Nov 3, 2024
Open
@mihirhbhatt mihirhbhatt mentioned this pull request Nov 3, 2024
Merged
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 3, 2024
Open
@PietroBossolasco PietroBossolasco mentioned this pull request Nov 3, 2024
Open
@Waffelmeister Waffelmeister mentioned this pull request Nov 3, 2024
Merged
@AndrewTroll AndrewTroll mentioned this pull request Nov 3, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 7, 2024
Merged
@Tobsukka Tobsukka mentioned this pull request Nov 8, 2024
Open
@k2xl k2xl mentioned this pull request Nov 8, 2024
Closed
@MihikaNigam MihikaNigam mentioned this pull request Nov 8, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Nov 8, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Nov 8, 2024
Merged
@AntenehTsegayeTessema AntenehTsegayeTessema mentioned this pull request Nov 8, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Nov 9, 2024
Open
This was referenced Nov 9, 2024
Merged
Closed
@aviraj1703 aviraj1703 mentioned this pull request Nov 9, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 9, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 10, 2024
Open
@axqqt axqqt mentioned this pull request Nov 10, 2024
Open
@AndrewTroll AndrewTroll mentioned this pull request Nov 11, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Nov 11, 2024
Open
This was referenced Nov 11, 2024
Merged
Merged
@desujoy desujoy mentioned this pull request Nov 11, 2024
Merged
@axqqt axqqt mentioned this pull request Nov 11, 2024
Open
@sachinthapa572 sachinthapa572 mentioned this pull request Nov 11, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Nov 12, 2024
Merged
@Yogananda1504 Yogananda1504 mentioned this pull request Nov 12, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 12, 2024
Merged
@zntb zntb mentioned this pull request Nov 12, 2024
Merged
@JasperVanNiekerk JasperVanNiekerk mentioned this pull request Nov 12, 2024
Open
@KovacevicAleksa KovacevicAleksa mentioned this pull request Nov 12, 2024
Merged
@ST10029788 ST10029788 mentioned this pull request Nov 12, 2024
Open
@zntb zntb mentioned this pull request Nov 13, 2024
Merged
@pradumchintamani pradumchintamani mentioned this pull request Nov 13, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hasezoey hasezoey Awaiting requested review from hasezoey

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.7.1
Development

Successfully merging this pull request may close these issues.

Cast to Buffer failed after updating from version 8.5.2 to 8.6.3
1 participant
@vkarpov15