Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docs(model): add more info on acknowledged: false, specifically that Mongoose may return that if the update was empty #14957

Merged
merged 1 commit into from
Oct 14, 2024
Merged

docs(model): add more info on acknowledged: false, specifically that Mongoose may return that if the update was empty #14957

merged 1 commit into from
Oct 14, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14951

Summary

Help clarify why #14951 is happening

Examples

@vkarpov15
docs(model): add more info on acknowledged: false, specifically that …
b7f33e7 
…Mongoose may return that if the update was empty

Fix #14951
@vkarpov15 vkarpov15 added this to the 8.7.2 milestone Oct 11, 2024
@markstos
Copy link
Contributor

Looks good to me. If people end up after upgrading to Mongoose 6 because they are have started getting acknowledged:false, see this discussion about one possible reason that appeared for me during the Mongoose 6 upgrade:

#14936

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Oct 12, 2024
@vkarpov15 vkarpov15 merged commit ccf4ffa into master Oct 14, 2024
58 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14951 branch October 15, 2024 09:12
@Tobsukka Tobsukka mentioned this pull request Nov 8, 2024
Open
@k2xl k2xl mentioned this pull request Nov 8, 2024
Closed
@MihikaNigam MihikaNigam mentioned this pull request Nov 8, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Nov 8, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Nov 8, 2024
Merged
@AntenehTsegayeTessema AntenehTsegayeTessema mentioned this pull request Nov 8, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Nov 9, 2024
Open
This was referenced Nov 9, 2024
Merged
Closed
@aviraj1703 aviraj1703 mentioned this pull request Nov 9, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 9, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 10, 2024
Open
@axqqt axqqt mentioned this pull request Nov 10, 2024
Open
@AndrewTroll AndrewTroll mentioned this pull request Nov 11, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Nov 11, 2024
Open
This was referenced Nov 11, 2024
Merged
Merged
@desujoy desujoy mentioned this pull request Nov 11, 2024
Merged
@axqqt axqqt mentioned this pull request Nov 11, 2024
Open
@sachinthapa572 sachinthapa572 mentioned this pull request Nov 11, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Nov 12, 2024
Merged
@Yogananda1504 Yogananda1504 mentioned this pull request Nov 12, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 12, 2024
Merged
@zntb zntb mentioned this pull request Nov 12, 2024
Merged
@JasperVanNiekerk JasperVanNiekerk mentioned this pull request Nov 12, 2024
Open
@KovacevicAleksa KovacevicAleksa mentioned this pull request Nov 12, 2024
Merged
@ST10029788 ST10029788 mentioned this pull request Nov 12, 2024
Open
@zntb zntb mentioned this pull request Nov 13, 2024
Merged
@pradumchintamani pradumchintamani mentioned this pull request Nov 13, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@markstos markstos markstos approved these changes

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
8.7.2
Development

Successfully merging this pull request may close these issues.

acknowledged: false should also generate descriptive logging
3 participants
@vkarpov15 @markstos @hasezoey