Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(document): recursively clear modified subpaths when setting deeply nested subdoc to null #14963

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14952

Summary

Right now cleanModifiedSubpaths() cleans the modified paths from the affected subdoc and the top-level doc, but not any intermediate subdocs, which can cause false validation errors like in #14952.

Examples

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkarpov15 vkarpov15 merged commit 94b2873 into master Oct 17, 2024
58 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14952 branch October 17, 2024 16:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidationError on setting null on subdocument field after several other values being set
2 participants