Add Winback Offer UI #3434
Merged
Add Winback Offer UI #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiSikora
added
[Type] Feature
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
mebarbosa
reviewed
Jan 13, 2025
Comment on lines
+138
to
+139
| text = stringResource(LR.string.winback_offer_free_offer_description, "\$3.99"), | ||
| color = MaterialTheme.theme.colors.primaryText02, |
There was a problem hiding this comment.
Should we also localize the price? I mean, put the price converted in the country currency
There was a problem hiding this comment.
This will come from the API once the logic is connected.
mebarbosa
approved these changes
Jan 13, 2025
# Conflicts: # modules/features/profile/src/main/java/au/com/shiftyjelly/pocketcasts/profile/winback/WinbackOfferPage.kt
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Winback Offer UI.
Designs: G22KfZwL1Gv5yyxdTheF9H-fi-3_172
I asked about breaking "check out" text and will follow up on it if necessary: U02GX6BT12A/F088D0JL61H-slack-file
Testing Instructions
Screenshots or Screencast
Checklist
If this is a user-facing change, I have added an entry in CHANGELOG.md./gradlew spotlessApplyto automatically apply formatting/linting)I have considered whether it makes sense to add tests for my changesmodules/services/localization/src/main/res/values/strings.xmlI have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.I have tested any UI changes...