Add Help & feedback Winback UI #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiSikora
added
[Type] Feature
|
🚧 Prototype builds will be available soon |
MiSikora
changed the title
geekygecko
reviewed
Jan 15, 2025
| @@ -116,18 +116,37 @@ open class BaseDialogFragment : BottomSheetDialogFragment(), CoroutineScope { | |||
| } | |||
| } | |||
|
|
|||
| protected fun styleBackgroundColor( | |||
| @ColorInt background: Int, | |||
| protected fun setDialogTint( | |||
There was a problem hiding this comment.
I have changed this method in the edge-to-edge project. 🙈
geekygecko
approved these changes
Jan 15, 2025
MiSikora
force-pushed
the
task/help-fragment-compose
branch
from
b909004 to
e23b9a0
Compare
MiSikora
force-pushed
the
task/winback-help-and-feedback-ui
branch
from
dbb23df to
60a1477
Compare
mebarbosa
pushed a commit
that referenced
this pull request
Jan 16, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds winback help UI. I had to redesign Logs page to split logs into separate lines that are fed into a
LazyColumn. Performance of a single long text was really bad, especially during navigation.Designs: G22KfZwL1Gv5yyxdTheF9H-fi-1_894
Testing Instructions
Screenshots or Screencast
Checklist
If this is a user-facing change, I have added an entry in CHANGELOG.md./gradlew spotlessApplyto automatically apply formatting/linting)I have considered whether it makes sense to add tests for my changesAll strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xmlAny jetpack compose components I added or changed are covered by compose previewsI have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.I have tested any UI changes...