Prevent next/previous arrows from being announced by screen readers #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope that this is just poorly titled; this should be preventing the next/previous arrows from being announced, not the buttons. I looked at the code, but that diff isn't exactly helpful. |
trymebytes
force-pushed
the
aria-hide-arrow
branch
from
e677b05 to
999276c
Compare
trymebytes
changed the title
|
@joedolson thanks for catching that, I have edited the title. The diff here is a compiled version of the js and css. I tested and found out that the arrows were still being read out but I have added another fix in this PR which solves it. |
|
I am not sure the PR is doing what it says. When I use Voiceover on macOS it says "Next right arrow", should it just say "Next"?
|
akirk
approved these changes
Dec 22, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34 and #32