Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update http-concat to upstream b5c28eea97aca9205ba65048d8f8b1f9e54a6d60 #6108

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rinatkhaziev
Copy link
Contributor

@rinatkhaziev rinatkhaziev commented Jan 22, 2025

Description

Pull in the latest changes:

Automattic/nginx-http-concat#80
Automattic/nginx-http-concat#78

Changelog Description

Fixed

  • CSS/JS Concatenation now correctly handles urlencoded values

Changed

  • CSS/JS Concatenation automatically breaks assets into smaller groups when reaching a threshold of 150 items in the group rather than simply throwing a 400 Bad Request

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

  1. Check out the PR locally and change the value, verify that in dev-env groups are being split correctly and there are no 400 responses from /_static/ when rendering a page in the browser.
  2. Grab any /_static/ url, urlencode the query part, paste back in the browser and make sure CSS or JS renders and there's no 400 response.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant