-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
DevTools should not add visual elements to its logical tree #17443
base: master
Are you sure you want to change the base?
DevTools should not add visual elements to its logical tree #17443
Conversation
You can test this PR using the following package version. |
|
@cla-avalonia agree |
046dcf8
to
8e25950
Compare
What problem does it solve? |
You can test this PR using the following package version. |
@maxkatz6 I've noticed a rather strange bug in v.11.2 - visual elements disappear from the visual tree after inspection with DevTools. <TabControl>
<TabItem Header="Item1">
<Button>button1</Button>
</TabItem>
<TabItem Header="Item2">
<Button>button2</Button>
</TabItem>
</TabControl> AvaloniaApplication5_bAxslwekDg.mp4I think it happens because the ContentControl in the ControlDetailsView puts its content in its logical tree. So, I did this PR to make sure that I got it right. |
You can test this PR using the following package version. |
8e25950
to
6bb9c29
Compare
You can test this PR using the following package version. |
What does the pull request do?
This PR makes sure that the visual elements are not added to the DevTools logical tree.
What is the current behavior?
Currently in 11.2, visual elements can be added to the DevTools logical tree. This can causes the app's visual tree to break.
AvaloniaApplication5_bAxslwekDg.mp4
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues