Gradual Dutch Auction Module #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJem
reviewed
May 1, 2024
install.sh
Outdated
| @@ -21,7 +21,7 @@ cd lib/forge-std/ && git checkout v1.7.1 && cd ../.. | |||
|
|
|||
| echo "" | |||
| echo "prb-math" | |||
| cd lib/prb-math/ && git checkout v4.0.2 && cd ../.. | |||
| cd lib/prb-math/ && git checkout main && cd ../.. | |||
There was a problem hiding this comment.
I'd suggest pinning this to a commit eventually
There was a problem hiding this comment.
I plan to. I just set it to main incase I needed to push any more changes to the library. Will leave this convo open as a reminder.
…i factory) changes, log the address and revert. Also consolidate the addresses used in tests and salt generation into one contract.
Oighty
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean implementation based on new priorities for #1 and the updated codebase.
Tasks: