Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/lint supported shells only #31

Merged
merged 5 commits into from
Jun 4, 2021

Conversation

Azbagheri
Copy link
Owner

@Azbagheri Azbagheri commented Jun 4, 2021

Pull Request Checklist

  • I have created an issue prior to creating this pull request
  • I have provided a detailed description and motivation regarding the change below
  • I have updated the test suite and documentation to support my change

Corresponding Issue

<ADD-ISSUE-HERE>

Description of Change

Adding support for scanning Shellcheck supported scripts only. 

Motivation and Context

Some of our users are using the action to scan directories with various types of scripts including some none-shell scripts that don't have any extension and instead use the shebang to point to the corresponding interpreter. With these changes, Shell Linter now checks the interpreter passed in the shebang and only allows the shellcheck supported ones.

Testing Steps

Added integration tests to cover these changes and they are all run in the pipeline. Locally they can be run using `./tests/test_runner`

Risks

Additional Information

@asadmansr asadmansr self-requested a review June 4, 2021 02:41
@Azbagheri Azbagheri merged commit 09e7d15 into develop Jun 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants