Upgrade Shellcheck (fixes #34) #37
Conversation
Azbagheri
changed the title
Azbagheri
changed the title
|
|
||
| wget -qO- "https://github.com/koalaman/shellcheck/releases/download/${scversion?}/shellcheck-${scversion?}.linux.x86_64.tar.xz" | tar -xJv | ||
| sudo cp "shellcheck-${scversion}/shellcheck" /usr/bin/ | ||
| cp "shellcheck-${scversion}/shellcheck" /usr/local/bin |
There was a problem hiding this comment.
Interesting side-note ~ check out the shellcheck-alpine image. They also seem to remove the shellcheck-${tag} folder
There was a problem hiding this comment.
I like the idea of a cleaning up the unnecessary files/folders post installation! Made the change in our script as well!
src/install_shellcheck.sh
Outdated
| @@ -1,8 +1,8 @@ | |||
| #! /bin/bash | |||
| #!/bin/bash | |||
|
|
|||
| # Update shellcheck to the locked v0.7.0 version through the binary distribution | |||
There was a problem hiding this comment.
Should we update this comment? Might be a good practice to indicate why we're updating?
There was a problem hiding this comment.
Good catch!! I actually removed the comment from the script because in general we shouldn't always have a reason to upgrade. It's a good practice to use the latest stable version. With that said, if we ever need to lock down the shellchck version to something older than the latest version, then we need to leave a comment.
…ck version. Also upgraded the base image used in the Shell Linter's Dockerfile.
…ck installation script
…d use the right script
…s it is not managed by the distribution and we won't need to use sudo in the script
…n by removing the shellcheck folder after the shellcheck executable is added to the path
Azbagheri
force-pushed
the
feature/upgrade-shellcheck
branch
from
7f71087 to
e498b4f
Compare
Pull Request Checklist
Corresponding Issue
Description of Change
Motivation and Context
Testing Steps
Risks
Additional Information