Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Spike: should we consider moving some core merkle functions from circuits to bberg? #1048

Closed
dbanks12 opened this issue Jul 12, 2023 · 0 comments
Closed

Spike: should we consider moving some core merkle functions from circuits to bberg? #1048

dbanks12 opened this issue Jul 12, 2023 · 0 comments

Comments

@dbanks12
Copy link
Collaborator

Replaces issue from old repo: AztecProtocol/aztec3-circuits#247

It's low priority, but the functions in the Merkle Tree class could mostly be removed in favour of a few:

Compute a root from a set of leaves
Compute a root using a value, leaf index, and sibling path
Get a sibling path

We've written some functions that do this inside the circuits c++ code - they should be moved as part of this refactor.

That's about it...?
@dbanks12 dbanks12 added this to A3 Jul 12, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 12, 2023
@dbanks12 dbanks12 mentioned this issue Jul 12, 2023
Closed
ludamad pushed a commit that referenced this issue Jul 14, 2023
@zac-williamson @critesjosh @iAmMichaelConnor
Zw/update aztec connect specs (#1048)
424157a 
* updated account circuit

* updated account circuit formatting

* updated schnorr spec

* updated intro

* fix typo

* updates in line with PR comments and rebase

Co-authored-by: Josh <critesjosh@gmail.com>
Co-authored-by: iAmMichaelConnor <mike@aztecprotocol.com>
ludamad pushed a commit that referenced this issue Jul 14, 2023
@PhilWindle @joss-aztec
@LHerskind @jonybur @zac-williamson @critesjosh @iAmMichaelConnor @LeilaWang
V2.1 testnet (#1380)
c161fd0 
* Audit preperation (#1305)

* compiler warnings

* add solhint + fix small linter issues

* remove skipped tests

* update rollup address

* add underscores on arguments in IVerifier

* JB/Move global error to toast group (#1251)

* Move global error message inside toast group

* Mini refactor

* Mini refactor

* Add deferrals

* Blockchain test jest -> mocha update (#1314)

* run jest-to-mocha script

* Manually fix the last test + add coverage + formatting

* extend mocha timeout + bump optimizer runs

* decrease optimizer runs to deploy old rollup processor in testing

* remove coverage package, install on demand

* make solidity-coverage import a comment in hardhat config

* JB/Fix settlement times (#1315)

Fix batched time, fix button regression

* JB/Allow for debug to be exportable (#1313)

* Allow for debug to be exportable

* Remove exportable debug

* Rollback

* Refactor

* Tweak export logs

* Upgrade to latest bridge clients (#1319)

- Align with interface on latest bridge-clients
- Correct stETH address
- Calc element ROI via getTermAPR
- Calc stETH via getUnderlyingAsset

* Explain when to squash vs merge (#1302)

* Zw/update aztec connect specs (#1048)

* updated account circuit

* updated account circuit formatting

* updated schnorr spec

* updated intro

* fix typo

* updates in line with PR comments and rebase

Co-authored-by: Josh <critesjosh@gmail.com>
Co-authored-by: iAmMichaelConnor <mike@aztecprotocol.com>

* Implemented rate limiting of deposits and address blacklist (#1323)

* Implemented rate limiting of deposits and address blacklist

* Cleanup

* Additionally check num deposits in tx receiver (#1326)

* Additionally check num deposits in tx receiver

* Sanity check input

* Additional tests (#1327)

* JB/Connect yearn bridge (#1334)

* Add yearn recipe

* Connect yearn bridge

* Fix toast z-index

* Fix price estimation for yearn bridge

* Take out console log

* Set up yvDAI bridge config

* Add styling for yearn (wip)

* Add price fetcher for yvDAI and yvETH

* Fix icon

* Fix exit modal

* Fixes and improvements

* Add collapse button to Toast component (#1322)

* don't expose blacklist (#1352)

* don't expose blacklist

* don't use delete keyword

* fix status endpoint types

* format

* fix server

* fix server

* Expose blacklist as undefined from public api.

Co-authored-by: Leila Wang <leizciw@gmail.com>

* Jcf/hotfix yearn exit (#1356)

* - allow exiting via a different bridgeAddressId
- fix incorrect batch info shown for exiting
- more explicit name: useDefaultEnterBridgeCallData
- fix wstETH price fetch regression

* upgrade bridge clients

* explicitly upgrade ethers

* Jcf/element hotfixes (#1377)

- safe number to bigint conversion
- fix default element term apr when entering
- infer async from recipe, not interaction result

Co-authored-by: joss-aztec <94053499+joss-aztec@users.noreply.github.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
Co-authored-by: Jonathan Bursztyn <jobur93@gmail.com>
Co-authored-by: Zachary James Williamson <blorktronics@gmail.com>
Co-authored-by: Josh <critesjosh@gmail.com>
Co-authored-by: iAmMichaelConnor <mike@aztecprotocol.com>
Co-authored-by: Joe Andrews <joe@creditmint.io>
Co-authored-by: Leila Wang <leizciw@gmail.com>
codygunton pushed a commit that referenced this issue Jan 23, 2024
@zac-williamson @critesjosh @iAmMichaelConnor
Zw/update aztec connect specs (#1048)
3c69f46 
* updated account circuit

* updated account circuit formatting

* updated schnorr spec

* updated intro

* fix typo

* updates in line with PR comments and rebase

Co-authored-by: Josh <critesjosh@gmail.com>
Co-authored-by: iAmMichaelConnor <mike@aztecprotocol.com>
codygunton pushed a commit that referenced this issue Jan 23, 2024
@PhilWindle @joss-aztec
@LHerskind @jonybur @zac-williamson @critesjosh @iAmMichaelConnor @LeilaWang
V2.1 testnet (#1380)
f48b496 
* Audit preperation (#1305)

* compiler warnings

* add solhint + fix small linter issues

* remove skipped tests

* update rollup address

* add underscores on arguments in IVerifier

* JB/Move global error to toast group (#1251)

* Move global error message inside toast group

* Mini refactor

* Mini refactor

* Add deferrals

* Blockchain test jest -> mocha update (#1314)

* run jest-to-mocha script

* Manually fix the last test + add coverage + formatting

* extend mocha timeout + bump optimizer runs

* decrease optimizer runs to deploy old rollup processor in testing

* remove coverage package, install on demand

* make solidity-coverage import a comment in hardhat config

* JB/Fix settlement times (#1315)

Fix batched time, fix button regression

* JB/Allow for debug to be exportable (#1313)

* Allow for debug to be exportable

* Remove exportable debug

* Rollback

* Refactor

* Tweak export logs

* Upgrade to latest bridge clients (#1319)

- Align with interface on latest bridge-clients
- Correct stETH address
- Calc element ROI via getTermAPR
- Calc stETH via getUnderlyingAsset

* Explain when to squash vs merge (#1302)

* Zw/update aztec connect specs (#1048)

* updated account circuit

* updated account circuit formatting

* updated schnorr spec

* updated intro

* fix typo

* updates in line with PR comments and rebase

Co-authored-by: Josh <critesjosh@gmail.com>
Co-authored-by: iAmMichaelConnor <mike@aztecprotocol.com>

* Implemented rate limiting of deposits and address blacklist (#1323)

* Implemented rate limiting of deposits and address blacklist

* Cleanup

* Additionally check num deposits in tx receiver (#1326)

* Additionally check num deposits in tx receiver

* Sanity check input

* Additional tests (#1327)

* JB/Connect yearn bridge (#1334)

* Add yearn recipe

* Connect yearn bridge

* Fix toast z-index

* Fix price estimation for yearn bridge

* Take out console log

* Set up yvDAI bridge config

* Add styling for yearn (wip)

* Add price fetcher for yvDAI and yvETH

* Fix icon

* Fix exit modal

* Fixes and improvements

* Add collapse button to Toast component (#1322)

* don't expose blacklist (#1352)

* don't expose blacklist

* don't use delete keyword

* fix status endpoint types

* format

* fix server

* fix server

* Expose blacklist as undefined from public api.

Co-authored-by: Leila Wang <leizciw@gmail.com>

* Jcf/hotfix yearn exit (#1356)

* - allow exiting via a different bridgeAddressId
- fix incorrect batch info shown for exiting
- more explicit name: useDefaultEnterBridgeCallData
- fix wstETH price fetch regression

* upgrade bridge clients

* explicitly upgrade ethers

* Jcf/element hotfixes (#1377)

- safe number to bigint conversion
- fix default element term apr when entering
- infer async from recipe, not interaction result

Co-authored-by: joss-aztec <94053499+joss-aztec@users.noreply.github.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
Co-authored-by: Jonathan Bursztyn <jobur93@gmail.com>
Co-authored-by: Zachary James Williamson <blorktronics@gmail.com>
Co-authored-by: Josh <critesjosh@gmail.com>
Co-authored-by: iAmMichaelConnor <mike@aztecprotocol.com>
Co-authored-by: Joe Andrews <joe@creditmint.io>
Co-authored-by: Leila Wang <leizciw@gmail.com>
@dbanks12 dbanks12 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbanks12