-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(kernel): dont chop commitments when matched to transient reads #1079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbanks12 Excellent work overall with great improvements of old code along the way.
@@ -315,19 +357,16 @@ void common_contract_logic(DummyBuilder& builder, | |||
} | |||
} | |||
|
|||
void common_initialise_end_values(PreviousKernelData<NT> const& previous_kernel, | |||
KernelCircuitPublicInputs<NT>& public_inputs) | |||
void common_inner_ordering_initialise_end_values(PreviousKernelData<NT> const& previous_kernel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, common prefix is meant for re-usability and does not imply that all circuits use the pre-fixed method. Adding the "inner_ordering" is a bit too verbose in my opinion but I can live with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I wanted to make it more clear which circuits use them, but i think you're right that it's overkill.
8835072
to
3b3eccb
Compare
Description
Closes #1073
Checklist: