Add nonce to note hash. #1084
Merged
Add nonce to note hash. #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sirasistant
approved these changes
Jul 19, 2023
| ) -> Context { | ||
| let mut note_hash = 0; | ||
| ) -> (Context, Note) { | ||
| let mut note_with_header = note; |
There was a problem hiding this comment.
Should this method check for equality of the read note with the passed note?
| // Noir (ACVM) expects a flattened (basically serialized) array of ACVMFields | ||
| const dbPreimages = dbNotes.flatMap(({ preimage }) => preimage).map(f => toACVMField(f)); | ||
|
|
||
| // TODO: Sort again. |
There was a problem hiding this comment.
Should we move to a transactional approach for the DB? and we drop the TX after finishing simulation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1019
Checklist: