feat: PrivateKey type
#1232
Merged
feat: PrivateKey type
#1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.
|
|
merging master to check the l1 contracts ci issue is fixed |
benesjan
force-pushed
the
janb/private-key-type
branch
2 times, most recently
from
ea80040 to
7bf6ed0
Compare
spypsy
reviewed
Jul 27, 2023
yarn-project/aztec-cli/src/index.ts
Outdated
| @@ -9,8 +9,8 @@ import { | |||
| createAztecRpcClient, | |||
| getAccountWallet, | |||
| } from '@aztec/aztec.js'; | |||
| import { PrivateKey } from '@aztec/circuits.js'; | |||
There was a problem hiding this comment.
you can export this from aztec.js to avoid bringing in the extra dependency.
I can also do it in my PR as I've done a few of these already
There was a problem hiding this comment.
I think it would make sense to export that through types package (that one is in deps). Will do it like that.
There was a problem hiding this comment.
Addressed in 12cc87f
benesjan
force-pushed
the
janb/private-key-type
branch
from
7bf6ed0 to
12cc87f
Compare
spypsy
reviewed
Jul 27, 2023
benesjan
force-pushed
the
janb/private-key-type
branch
from
f7b889c to
2e8f0ed
Compare
spypsy
approved these changes
Jul 27, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
yarn-project/circuits.js/src/types/partial_contract_address.tsto individual files.scalarparam toprivateKeybecause having scalar being typePrivateKeyis weird and we don't ever use these classes with scalars which are not a representation of private key. For this reason I think it's ok to have the parameter name be less generic. Another alternative I considered was having aScalartype andPrivateKeybeing a type alias of it but given that we don't use non-private-key scalar anywhere in our TS codebase I think that's unnecessary complication.e2e-account-contracttoe2e-account-contracstso that the job name is consistent with the test name.Checklist: