Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove IDs use placeholders #769

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kengaderdus
Copy link

@kengaderdus kengaderdus commented May 13, 2024

Remove IDs use placeholders

We're replacing all real GUIDs with visibly fakes ones or placeholders or replacing existing placeholders with easy to read ones

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

@jennyf19
Copy link
Contributor

thanks @kengaderdus but I don't see the value in this one...a lot of the previous content was more specific and actionable.

@kengaderdus
Copy link
Author

@jennyf19

We're removing real GUIDs and replacing them with placeholders or visibly fake GUIDs.

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that the app creation scripts were updated

@kengaderdus
Copy link
Author

@jmprieur I still don't understand your request. Can you point me to text that you think should have been updated?

@jmprieur
Copy link
Contributor

@kengaderdus: all chapters have app creation scripts that provide an app registration and the config of the app.
See https://github.com/Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2/blob/master/1-WebApp-OIDC/1-1-MyOrg/AppCreationScripts/Configure.ps1 for instance.

For the B2C sample, not sure if we can accept this as setting-up B2C is a lot of work for customers.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants