-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
@archieag FYI |
JavaScriptSPA/index.html
Outdated
<!-- polyfilling fetch --> | ||
<script type="text/javascript" src="https://cdn.jsdelivr.net/npm/whatwg-fetch/dist/fetch.umd.min.js"></script> | ||
<!-- depending on your browser you might want to include babel polyfill --> | ||
<script type="text/javascript" src="https://cdn.jsdelivr.net/npm/@babel/polyfill@7.4.4/dist/polyfill.min.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was adding pollyfills for ie11 support but there are a bunch of other things that still don't work and forcing a very restricted js usage (at least without something like npm and babel).
Happily though, I've just been told by a few CxP people that aad samples can drop support for ie11. Removing this part then.
README.md
Outdated
@@ -4,7 +4,6 @@ languages: | |||
- javascript | |||
products: | |||
- microsoft-identity-platform | |||
- azure-active-directory-v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seems relevant, why was it removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the impression that for new samples microsoft identity platform
should replace azure active directory v2
(at least that's what dotnet samples are doing)
JavaScriptSPA/authPopup.js
Outdated
|
||
// fallback to interaction when silent call fails | ||
return myMSALObj.acquireTokenPopup(request) | ||
.then(tokenResponse => {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will result in nothing getting returned from getTokenPopup
. Either omit this .then
, or make sure this chain returns tokenResponse
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. kept it there to keep the pattern:
return myMSALObj.acquireTokenPopup(request)
.then(tokenResponse => {
return tokenResponse;
}).catch(error => {
console.log(error);
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, I was able to run the redirect and popup sample as expected.
Thank you very much for all the reviews! Merging this now.. |
CHANGELOG