Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: remove unnecessary config lines #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

krukowskid
Copy link

@krukowskid krukowskid commented Nov 22, 2023

Purpose

Hey @paolosalvatori, thank you for this content!
I have removed azure.workload.identity/use: "true" from code samples, because its not valid for service account https://azure.github.io/azure-workload-identity/docs/topics/service-account-labels-and-annotations.html#service-account

I have also removed azure.workload.identity/tenant-id: ${tenantId} annotation because it defaults to tenantId value set during wi installation.

    helm install $releaseName $repoName/$chartName \
        --namespace $namespace \
        --create-namespace \
        --set azureTenantID="$tenantId"

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

@krukowskid
Copy link
Author

@microsoft-github-policy-service agree

@paolosalvatori
Copy link
Contributor

Thanks @krukowskid, I wrote the article when the Workload Identity was still in preview, so in the meantime, a few things have changed, and I missed refreshing the sample. 😸

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants