Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding preptask sample #266

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Conversation

manishshar
Copy link

Adding a sample preparation task for batch samples.

Thanks
Manish

@bgklein
Copy link
Contributor

bgklein commented Feb 28, 2019

Code LGTM.

Could you add some details on the sample to the README

Thematically I think it would make sense to swap this to sample3 and move that current sample 3 to 4 mainly due to complexity but I'll leave that discretion to @alfpark and @matthchr

@manishshar
Copy link
Author

Hi @bgklein

Thanks for your response.
I have done changes in document as well. Please check.

Thanks
Manish

@manishshar
Copy link
Author

Hi
Could you please review? Pls let me know if anything is need.

-Manish

Python/Batch/README.md Outdated Show resolved Hide resolved
Python/Batch/README.md Outdated Show resolved Hide resolved
Python/Batch/README.md Outdated Show resolved Hide resolved
Python/Batch/README.md Outdated Show resolved Hide resolved
Python/Batch/sample4_preparationtask.py Outdated Show resolved Hide resolved
Python/Batch/sample4_preparationtask.py Outdated Show resolved Hide resolved
Python/Batch/sample4_preparationtask.cfg Outdated Show resolved Hide resolved
@bgklein
Copy link
Contributor

bgklein commented Apr 23, 2019

@alfpark / @matthchr / @darylmsft I don't have ownership of this repo. If one of you could take a final look and merge/make any last suggestions that would be great

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants