Skip to content

Redirect if text query param missing #20

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Conversation

ibidani
Copy link
Contributor

@ibidani ibidani commented Jun 27, 2020

Purpose

  • Logs present the function default url as below, if user browse to it, they will get an error 500
Now listening on: http://0.0.0.0:7071
Application started. Press Ctrl+C to shut down.

Http Functions:

        sentiment: [GET,POST] http://localhost:7071/api/sentiment

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Browsing to the URL without text query param should redirect to URL with text=I+Love+PyCon

Other Information

@asw101
Copy link
Collaborator

asw101 commented Jul 10, 2020

Thank you @ibidani, I think this certainly adds to the usability of the lab!

@asw101 asw101 merged commit 795ae72 into Azure-Samples:master Jul 10, 2020
@ibidani
Copy link
Contributor Author

ibidani commented Jul 12, 2020

Thanks, tiny polish

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants