Fix panic when set snapshotName selector #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR fixes a panic related to setting the snapshotName selector by extending support for a snapshotName field in provider specs and corresponding filters.
- Adds test cases for snapshotName in both key value and feature flag selectors
- Updates the filter normalization function to propagate the SnapshotName field
- Enhances controller tests by including snapshotName fields in the configuration
Reviewed Changes
| File | Description |
|---|---|
| internal/loader/configuraiton_setting_loader_test.go | Adds tests for including snapshotName in key value and feature flag filters |
| internal/controller/appconfigurationprovider_controller_test.go | Introduces snapshotName test properties for the provider controller |
| internal/loader/configuration_setting_loader.go | Updates normalizeLabelFilter in the loader to copy over the SnapshotName from the incoming selectors |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
RichardChen820
approved these changes
Feb 27, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.