FIX unblock test pipelines by skipping certain tests on Ubuntu and adding Windows additionally #727
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
changed the title
rlundeen2
approved these changes
Feb 20, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After originally getting confused about what caused tests to suddenly fail (the only change we identified were a transformers upgrade to 4.49.0) we found that the huggingface chat target tests had a fixture that wasn't working. Curiously, it failed only in the pipeline on GH, but not locally which made reproducing hard. We investigated using windows instead of ubuntu which didn't change anything, but having multiple OSes for tests is a good addition anyway. Finally, @jsong468 found the correct way to mock
download_specific_fileswhich we now use.Tests and Documentation
All updates are to tests!