[Modules] NetApp nfs41 adding principalType to RBAC (#2213)

* principalType * readme
Azure · Oct 13, 2022 · aeb30cf · aeb30cf
1 parent f362c96
commit aeb30cf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/modules/Microsoft.NetApp/netAppAccounts/.test/nfs41/deploy.test.bicep b/modules/Microsoft.NetApp/netAppAccounts/.test/nfs41/deploy.test.bicep
@@ -51,6 +51,7 @@ module testDeployment '../../deploy.bicep' = {
               resourceGroupResources.outputs.managedIdentityPrincipalId
             ]
             roleDefinitionIdOrName: 'Reader'
+            principalType: 'ServicePrincipal'
           }
         ]
         serviceLevel: 'Premium'
@@ -77,6 +78,7 @@ module testDeployment '../../deploy.bicep' = {
                   resourceGroupResources.outputs.managedIdentityPrincipalId
                 ]
                 roleDefinitionIdOrName: 'Reader'
+                principalType: 'ServicePrincipal'
               }
             ]
             subnetResourceId: resourceGroupResources.outputs.subnetResourceId
@@ -110,6 +112,7 @@ module testDeployment '../../deploy.bicep' = {
               resourceGroupResources.outputs.managedIdentityPrincipalId
             ]
             roleDefinitionIdOrName: 'Reader'
+            principalType: 'ServicePrincipal'
           }
         ]
         serviceLevel: 'Premium'
@@ -123,6 +126,7 @@ module testDeployment '../../deploy.bicep' = {
           resourceGroupResources.outputs.managedIdentityPrincipalId
         ]
         roleDefinitionIdOrName: 'Reader'
+        principalType: 'ServicePrincipal'
       }
     ]
     tags: {

diff --git a/modules/Microsoft.NetApp/netAppAccounts/readme.md b/modules/Microsoft.NetApp/netAppAccounts/readme.md
@@ -437,6 +437,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
             principalIds: [
               '<managedIdentityPrincipalId>'
             ]
+            principalType: 'ServicePrincipal'
             roleDefinitionIdOrName: 'Reader'
           }
         ]
@@ -463,6 +464,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
                 principalIds: [
                   '<managedIdentityPrincipalId>'
                 ]
+                principalType: 'ServicePrincipal'
                 roleDefinitionIdOrName: 'Reader'
               }
             ]
@@ -496,6 +498,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
             principalIds: [
               '<managedIdentityPrincipalId>'
             ]
+            principalType: 'ServicePrincipal'
             roleDefinitionIdOrName: 'Reader'
           }
         ]
@@ -509,6 +512,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
         principalIds: [
           '<managedIdentityPrincipalId>'
         ]
+        principalType: 'ServicePrincipal'
         roleDefinitionIdOrName: 'Reader'
       }
     ]
@@ -550,6 +554,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
               "principalIds": [
                 "<managedIdentityPrincipalId>"
               ],
+              "principalType": "ServicePrincipal",
               "roleDefinitionIdOrName": "Reader"
             }
           ],
@@ -576,6 +581,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
                   "principalIds": [
                     "<managedIdentityPrincipalId>"
                   ],
+                  "principalType": "ServicePrincipal",
                   "roleDefinitionIdOrName": "Reader"
                 }
               ],
@@ -609,6 +615,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
               "principalIds": [
                 "<managedIdentityPrincipalId>"
               ],
+              "principalType": "ServicePrincipal",
               "roleDefinitionIdOrName": "Reader"
             }
           ],
@@ -624,6 +631,7 @@ module netAppAccounts './Microsoft.NetApp/netAppAccounts/deploy.bicep' = {
           "principalIds": [
             "<managedIdentityPrincipalId>"
           ],
+          "principalType": "ServicePrincipal",
           "roleDefinitionIdOrName": "Reader"
         }
       ]