Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix accelerated networking on VM #1055

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

MariusStorhaug
Copy link
Contributor

Change

As the default behavior of accelerated networking is enabled in the UI, I set it to true + fixed the logic for changing it.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented Feb 28, 2022

Unit Test Results

  1 files  ±    0    1 suites  ±0   30s ⏱️ - 1m 58s
10 tests  -   32  10 ✔️  - 32    0 💤 ±    0  0 ±0 
76 runs   - 310  10 ✔️  - 32  66 💤  - 278  0 ±0 

Results for commit abd3b79. ± Comparison against base commit 1e662cf.

This pull request removes 42 and adds 10 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers/immutabilityPolicies] used resource type [storageAccounts/blobServices/containers/immutabilityPolicies] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers] used resource type [storageAccounts/blobServices/containers/immutabilityPolicies] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers] used resource type [storageAccounts/blobServices/containers] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [storageAccounts/blobServices/containers/immutabilityPolicies] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [storageAccounts/blobServices/containers] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [storageAccounts/blobServices] should use on of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/fileServices/shares] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines/extensions] used resource type [virtualMachines/extensions] should use on of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [configurationProfileAssignments] should use on of the recent API version(s). Currently using [2021-04-30-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [networkInterfaces] should use on of the recent API version(s). Currently using [2021-03-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [publicIPAddresses] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [vaults/backupFabrics/protectionContainers/protectedItems] should use on of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [virtualMachines/extensions] should use on of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [virtualMachines] should use on of the recent API version(s). Currently using [2021-07-01]

♻️ This comment has been updated with latest results.

@MariusStorhaug MariusStorhaug merged commit 29d92d8 into main Feb 28, 2022
@MariusStorhaug MariusStorhaug deleted the users/mast/VMAcceleratedNetworking branch February 28, 2022 22:59
@MariusStorhaug MariusStorhaug self-assigned this May 19, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants