Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding properties to Azure Container Registry #1079

Merged
merged 24 commits into from
Mar 7, 2022
Merged

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Mar 4, 2022

Change

new properties and children added

ContainerRegistry: Registries

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@rahalan rahalan marked this pull request as draft March 4, 2022 12:50
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Unit Test Results

  1 files  ±    0  1 suites  ±0   29s ⏱️ - 1m 48s
  8 tests  -     1  8 ✔️  - 1    0 💤 ±    0  0 ±0 
72 runs   - 248  8 ✔️  - 1  64 💤  - 247  0 ±0 

Results for commit d7d28f8. ± Comparison against base commit 59d2602.

This pull request removes 9 and adds 8 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateDnsZones/AAAA] used resource type [privateDnsZones/AAAA] should use on of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateDnsZones/A] used resource type [privateDnsZones/A] should use on of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateDnsZones/CNAME] used resource type [privateDnsZones/CNAME] should use on of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateDnsZones/MX] used resource type [privateDnsZones/MX] should use on of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateDnsZones/PTR] used resource type [privateDnsZones/PTR] should use on of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateDnsZones/SOA] used resource type [privateDnsZones/SOA] should use on of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateDnsZones/SRV] used resource type [privateDnsZones/SRV] should use on of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateDnsZones/TXT] used resource type [privateDnsZones/TXT] should use on of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/privateDnsZones/virtualNetworkLinks] used resource type [privateDnsZones/virtualNetworkLinks] should use on of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries/replications] used resource type [registries/replications] should use on of the recent API version(s). Currently using [2021-12-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [privateEndpoints/privateDnsZoneGroups] should use on of the recent API version(s). Currently using [2021-02-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [privateEndpoints] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [registries/replications] should use on of the recent API version(s). Currently using [2021-12-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [registries] should use on of the recent API version(s). Currently using [2021-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr added [cat] modules category: modules enhancement New feature or request labels Mar 5, 2022
@rahalan rahalan marked this pull request as ready for review March 7, 2022 08:54
@rahalan rahalan enabled auto-merge (squash) March 7, 2022 08:54
Copy link
Contributor

@simonbMS simonbMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, but when possible, I would add all the new/changed parameters to the parameter file to make sure we test them

@rahalan rahalan merged commit 6eba4c0 into main Mar 7, 2022
@rahalan rahalan deleted the users/rahalan/UpdateACR branch March 7, 2022 13:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants