-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Load Balancer: Add better support for privateLB #1089
Conversation
…users/mast/LB-privateLB
…users/mast/LB-privateLB
arm/Microsoft.Network/loadBalancers/.parameters/internal.parameters.json
Outdated
Show resolved
Hide resolved
...s/pipelines/dependencies/Microsoft.Network/loadBalancers/parameters/internal.parameters.json
Outdated
Show resolved
Hide resolved
...s/pipelines/dependencies/Microsoft.Network/loadBalancers/parameters/internal.parameters.json
Outdated
Show resolved
Hide resolved
…eters.json Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…rs/parameters/internal.parameters.json Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@MrMCake @eriqua ready for a new look. Sorted the comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmadabdalla would there be a use case for that? In case of the VM the resources & conditions that are deployed differ quite a bit from windows to linux. Is the same true for LB? |
Not a use case more of one supporting a public ip and one doesn't. If we are introducing a new type, maybe the parameter names should align. Plus there is a new sku of 'gateway' and tier of 'global' which we are yet to support. This may introduce different properties combinations so we would end up with different files. |
@ahmadabdalla and @MrMCake: I don't see the need to introduce this now as there is currently no use case for it. We can add it 'when we get there' as its a change that would not affect the module validation or alignment at this point. Just a "lean" thought from my end on this issue. Lets not overthink it at this point. |
Change
Minor changes to have the LB be able to be used in a solution deployment. It allows a LB be deployed first, having VMs be deployed after to be put into the backendpool of the LB.
Also added a test for creating a private LB.
Type of Change
Please delete options that are not relevant.
Checklist