Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added public ip address bicep #129

Merged
merged 6 commits into from
Oct 6, 2021
Merged

Added public ip address bicep #129

merged 6 commits into from
Oct 6, 2021

Conversation

AlexanderSehr
Copy link
Contributor

Change

  • Added public ip address bicep
  • Pipeline reference
    Network: Publicipaddresses

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented Oct 6, 2021 •
edited
Loading

Unit Test Results

  1 files  ±0  1 suites  ±0   5s ⏱️ -3s
  2 tests  - 2  2 ✔️  - 2    0 💤 ±0  0 ❌ ±0 
41 runs   - 2  3 ✔️  - 2  38 💤 ±0  0 ❌ ±0 

Results for commit 8d430de. ± Comparison against base commit 953e704.

This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both. 
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [trafficmanagerprofiles] used resource type [deployments] should use on of the recent API version(s). Currently using [2019-10-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [trafficmanagerprofiles] used resource type [diagnosticSettings] should use on of the recent API version(s). Currently using [2017-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [trafficmanagerprofiles] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [trafficmanagerprofiles] used resource type [trafficmanagerprofiles] should use on of the recent API version(s). Currently using [2018-08-01]

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [publicIPAddresses] used resource type [deployments] should use on of the recent API version(s). Currently using [2020-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [publicIPAddresses] used resource type [publicIPAddresses] should use on of the recent API version(s). Currently using [2021-02-01]

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 6, 2021 14:37
eriqua
eriqua reviewed Oct 6, 2021
View reviewed changes
@eriqua
Copy link
Contributor

eriqua commented Oct 6, 2021

One general comment. For some reason I'm not able to see the publicIPAddresses/readme.md file. This is how it's shown in the PR Files section
image

eriqua
eriqua previously approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

eriqua
eriqua approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 1436751 into main Oct 6, 2021
@AlexanderSehr AlexanderSehr deleted the users/alsehr/bicep_pip branch October 10, 2021 10:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @eriqua