Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Modules] VirtualMachine: Configure boot diagnostics with managed storage account #1365

Merged
merged 201 commits into from
May 10, 2022
Merged

[Modules] VirtualMachine: Configure boot diagnostics with managed storage account #1365

merged 201 commits into from
May 10, 2022

Conversation

lsnoddy
Copy link
Member

@lsnoddy lsnoddy commented May 5, 2022

Description

Added bootDiagnostics parameter to enable boot diagnostics with a managed storage account when a custom storage account is not specified.

Pipeline references

Pipeline
Compute: VirtualMachines

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

lsnoddy and others added 30 commits November 15, 2021 17:30
@lsnoddy
Update to new child-resource structure progress
30d0ec1
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules int…
7b8ea9f 
…o main
@lsnoddy
Progress check-in
e725966
@lsnoddy
Added managed cluster name parameter
0454fa2
@lsnoddy
Updated readme
aad50a9
@lsnoddy
Merge branch 'Azure:main' into main
8e3f37e
@lsnoddy
Updated readme file
eb9ac8f
@lsnoddy
Updated readme
4895bfd
Push updated Readme file(s)
a24964d
@lsnoddy
Updated readme
9da3646
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
3ccc8dd
@lsnoddy
Added test param file
4210ecf
@lsnoddy
Updated subscriptionId
4ce1e3b
@lsnoddy
Added test param file
a9726f6
@lsnoddy
Removed subscription id
ed984d6
@lsnoddy
Modified test variables
0380167
@lsnoddy
Modified test variables
ecf407a
@lsnoddy
Test dependency values
40ffa48
@lsnoddy
Updated parameters
f03ac3a
@lsnoddy
Removed local files used for testing
d056b74
@lsnoddy
Merge branch 'Azure:main' into main
8f3447b
@lsnoddy
Updated readme
a792c19
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
d128feb
@lsnoddy
Updated readme
cc8c087
@lsnoddy
Revert "Push updated Readme file(s)"
30a00ca 
This reverts commit a24964d.
@lsnoddy
Updated readme
20a3955
@lsnoddy
Updated both readme files and agentPool paramter name consistency
5139c68
Push updated Readme file(s)
39ae6ce
@lsnoddy
Merge branch 'Azure:main' into main
20c6a88
@lsnoddy
Updated Api to API to appease linter
5621dcb
lsnoddy added 22 commits March 5, 2022 10:21
@lsnoddy
Merge branch 'Azure:main' into main
934ece5
@lsnoddy
Merge branch 'Azure:main' into main
da3432d
@lsnoddy
Merge branch 'Azure:main' into main
eb7050f
@lsnoddy
Merge branch 'Azure:main' into main
04f983a
@lsnoddy
Merge branch 'Azure:main' into main
508dfba
@lsnoddy
Upated main
d3bf7d6
@lsnoddy
Update to main
3933979
@lsnoddy
Update to main - stg acct version
6719364
@lsnoddy
Updates to main
dab04aa
@lsnoddy
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
60d947b 
…Azure-main
@lsnoddy
Merge branch 'Azure-main'
c0c74d6
@lsnoddy
Merge branch 'Azure:main' into main
ff6a82c
@lsnoddy
Merge branch 'Azure:main' into main
bba54df
@lsnoddy
Merge branch 'Azure:main' into main
9cc983b
@lsnoddy
Merge branch 'Azure:main' into main
d3340b2
@lsnoddy
Merge branch 'Azure:main' into main
2f9f815
@lsnoddy
Added bootDiagnostics w/managed storage acct
1da67d1
@lsnoddy
location update
a148ce6
@lsnoddy
Token update
f790cc3
@lsnoddy
Update encryption key
44ad130
@lsnoddy
Updated encryption key identifier
0b32635
@lsnoddy
Reset settings files
354a1b1
@lsnoddy lsnoddy self-assigned this May 5, 2022
@lsnoddy lsnoddy linked an issue May 5, 2022 that may be closed by this pull request
Virtual Machine should allow configuring boot diagnostics with "managed" storage account #1107
Closed
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label May 6, 2022
@eriqua eriqua changed the title VirtualMachine: Configure boot diagnostics with managed storage account [Modules] VirtualMachine: Configure boot diagnostics with managed storage account May 8, 2022
@AlexanderSehr AlexanderSehr merged commit 5e61e9f into Azure:main May 10, 2022
@lsnoddy lsnoddy deleted the users/lsnoddy/virtualMachineBootDiag branch May 10, 2022 13:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

@rahalan rahalan rahalan approved these changes

Assignees

@lsnoddy lsnoddy

Labels
[cat] modules category: modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Virtual Machine should allow configuring boot diagnostics with "managed" storage account
3 participants
@lsnoddy @AlexanderSehr @rahalan