Align locks accross all modules #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahalan
approved these changes
Oct 19, 2021
MariusStorhaug
suggested changes
Oct 19, 2021
| resource serviceBusNamespaceQueue_lock 'Microsoft.Authorization/locks@2016-09-01' = if (lockForDeletion) { | ||
| name: '${split(serviceBusNamespaceQueue.name, '/')[1]}-doNotDelete' | ||
| resource serviceBusNamespaceQueue_lock 'Microsoft.Authorization/locks@2016-09-01' = if (lock != 'NotSpecified') { | ||
| name: '${serviceBusNamespaceQueue.name}-${lock}-lock' |
There was a problem hiding this comment.
Not sure about the naming here. If the queue namespace would refer to full name or resource specific name
- '${split(serviceBusNamespaceQueue.name, '/')[1]}-doNotDelete'
+ '${serviceBusNamespaceQueue.name}-${lock}-lock'
| resource managedInstanceDatabase_lock 'Microsoft.Authorization/locks@2016-09-01' = if (lockForDeletion) { | ||
| name: '${split(managedInstanceDatabase.name, '/')[1]}-doNotDelete' | ||
| resource managedInstanceDatabase_lock 'Microsoft.Authorization/locks@2016-09-01' = if (lock != 'NotSpecified') { | ||
| name: '${managedInstanceDatabase.name}-${lock}-lock' |
There was a problem hiding this comment.
Not sure about the naming here. If the managedInstanceDatabase would refer to full name or resource specific name
- '${split(managedInstanceDatabase.name, '/')[1]}-doNotDelete'
+ '${managedInstanceDatabase.name}-${lock}-lock'
|
Binary?
Updated files, missing counterpart:
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Type of Change
Please delete options that are not relevant.
Checklist