Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Modules] Update Network LocalNetworkGateway to new dependency approach #2046

Merged
merged 5 commits into from
Oct 10, 2022
Merged

[Modules] Update Network LocalNetworkGateway to new dependency approach #2046

merged 5 commits into from
Oct 10, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Update Network LocalNetworkGateway to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: LocalNetworkGateways

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 16, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 16, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 16, 2022 that may be closed by this pull request
Update Network/localNetworkGateways to new dependencies approach #2045
Closed
@github-actions
Copy link

Unit Test Results

  1 files    1 suites   35s ⏱️
52 tests 51 ✔️ 1 💤 0 ❌
62 runs  60 ✔️ 2 💤 0 ❌

Results for commit 7ff48d0.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 18, 2022 21:45
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 18, 2022 21:45
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 10, 2022 17:45
@AlexanderSehr AlexanderSehr requested a review from eriqua October 10, 2022 17:45
eriqua
eriqua approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit e536d2e into main Oct 10, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_localNetworkGateways branch October 10, 2022 19:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Network/localNetworkGateways to new dependencies approach
2 participants
@AlexanderSehr @eriqua