Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Modules] Updated Service Bus Namespace to new dependencies approach #2220

Merged
merged 1 commit into from
Oct 15, 2022
Merged

[Modules] Updated Service Bus Namespace to new dependencies approach #2220

merged 1 commit into from
Oct 15, 2022

Conversation

ahmadabdalla
Copy link
Contributor

Closes #2217

Description

Updated Service Bus to latest dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ServiceBus: Namespaces

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added the [cat] modules category: modules label Oct 14, 2022
@ahmadabdalla ahmadabdalla added this to the Release v0.8.0 milestone Oct 14, 2022
@ahmadabdalla ahmadabdalla self-assigned this Oct 14, 2022
@ahmadabdalla ahmadabdalla changed the title [Modules] Updated Insight ActivityLogAlerts to new dependencies approach [Modules] Updated Service Bus Namespace to new dependencies approach Oct 14, 2022
@github-actions
Copy link

Unit Test Results

    1 files  ±  0      1 suites  ±0   2m 43s ⏱️ - 1m 9s
357 tests  - 84  351 ✔️  - 84  6 💤 ±0  0 ❌ ±0 
384 runs   - 91  375 ✔️  - 90  9 💤  - 1  0 ❌ ±0 

Results for commit 648aa13. ± Comparison against base commit 05d6a54.

@ahmadabdalla ahmadabdalla marked this pull request as ready for review October 14, 2022 09:09
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner October 14, 2022 09:10
@ahmadabdalla ahmadabdalla merged commit 0bbed35 into main Oct 15, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/2217_servicebus branch October 15, 2022 19:10
@eriqua eriqua removed this from the Release v0.8.0 milestone Nov 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@ahmadabdalla ahmadabdalla

Labels
[cat] modules category: modules [cat] testing category: testing hacktoberfest-accepted
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ServiceBus/namespaces to new dependencies approach
3 participants
@ahmadabdalla @AlexanderSehr @eriqua