Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI environment] updated GitHub workflows to use actions-checkout@v3 #2249

Merged
merged 2 commits into from
Oct 29, 2022

Conversation

ahmadabdalla
Copy link
Contributor

Closes #2215

Description

As per the issue, upgraded the workflows to use the new checkout@v3 instead of the existing checkout@v2.

Tackled in #2211

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ManagedIdentity: UserAssignedIdentities
Network: ApplicationSecurityGroups

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • [ ]

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added the enhancement New feature or request label Oct 24, 2022
@ahmadabdalla ahmadabdalla self-assigned this Oct 24, 2022
@github-actions
Copy link

github-actions bot commented Oct 28, 2022

Unit Test Results

52 tests  ±0   50 ✔️  - 1   34s ⏱️ -1s
  1 suites ±0     2 💤 +1 
  1 files   ±0     0 ±0 

Results for commit 5f9aacc. ± Comparison against base commit aff7708.

This pull request removes 52 and adds 52 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.VirtualMachineImages/imageTemplates] used resource type [imageTemplates] should use one of the recent API version(s). Currently using [2020-02-14]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.VirtualMachineImages/imageTemplates] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.VirtualMachineImages/imageTemplates] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.VirtualMachineImages/imageTemplates] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.VirtualMachineImages/imageTemplates] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.VirtualMachineImages/imageTemplates] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.VirtualMachineImages/imageTemplates] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.VirtualMachineImages/imageTemplates] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.VirtualMachineImages/imageTemplates] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.VirtualMachineImages/imageTemplates] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ManagedIdentity/userAssignedIdentities] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ManagedIdentity/userAssignedIdentities] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ManagedIdentity/userAssignedIdentities] used resource type [userAssignedIdentities] should use one of the recent API version(s). Currently using [2018-11-30]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
…
This pull request removes 1 skipped test and adds 2 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.VirtualMachineImages/imageTemplates] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.ManagedIdentity/userAssignedIdentities] *parameters.json files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

@ahmadabdalla ahmadabdalla marked this pull request as ready for review October 28, 2022 23:02
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner October 28, 2022 23:02
@ahmadabdalla ahmadabdalla merged commit 6925b2c into main Oct 29, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/2215_nodeJsUpgrade branch October 29, 2022 12:05
@eriqua eriqua changed the title [Feature Request] updated GitHub workflows to use actions-checkout@v3 [CI environment] updated GitHub workflows to use actions-checkout@v3 Nov 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Upgrade actions to use Node.js 16 warning - upgrade checkout action to v3
3 participants