Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fixes] Applied a fix to handle inline quotations (e.g. for commands) #2280

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 4, 2022

Description

  • Applied a fix to handle inline quotations (e.g. for commands)
    Example:
    commandToExecute: 'value=$(./${last(split(resourceGroupResources.outputs.storageAccountCSEFileUrl, '/'))}); echo "$value"'
    would currently be rendered to
    commandToExecute: "value=$(./${last(split(resourceGroupResources.outputs.storageAccountCSEFileUrl, '/'))}); echo "$value""
    but with the fix, it is
    commandToExecute: "value=$(./${resourceGroupResources.outputs.storageAccountCSEFileName}); echo \"$value\""
  • Tested the generation on all components without any undesired changes

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr added bug Something isn't working [cat] modules category: modules labels Nov 4, 2022
@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 4, 2022 18:12
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner November 4, 2022 18:12
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 4, 2022 18:12
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 66ce937 into main Nov 7, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/readmeQuoteationUpdate branch November 7, 2022 08:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants