Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Fixes] Fix DataProtection Backup Vaults #2307

Merged
merged 8 commits into from
Nov 18, 2022
Merged

[Fixes] Fix DataProtection Backup Vaults #2307

merged 8 commits into from
Nov 18, 2022

Conversation

JPEasier
Copy link
Contributor

@JPEasier JPEasier commented Nov 10, 2022 •
edited
Loading

Description

#2160
Due to a change in Azure API one of the properties of backupVault are invalid.
StorageSettings.datastoreType value was SnapshotStore and now OperationalStore.

  • Update API version.
  • Update readme.md.

Pipeline references

Pipeline
DataProtection: BackupVaults

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@JPEasier JPEasier requested a review from a team as a code owner November 10, 2022 12:07
@JPEasier JPEasier linked an issue Nov 10, 2022 that may be closed by this pull request
Fix DataProtection Backup Vaults #2160
Closed
@JPEasier JPEasier self-assigned this Nov 10, 2022
@eriqua eriqua changed the title Fix DataProtection Backup Vaults [Fixes] Fix DataProtection Backup Vaults Nov 10, 2022
@eriqua eriqua added the [cat] modules category: modules label Nov 10, 2022
@JPEasier JPEasier requested a review from eriqua November 18, 2022 08:01
@JPEasier JPEasier merged commit f5ddbd5 into main Nov 18, 2022
@JPEasier JPEasier deleted the feature/2160-dataprotection branch November 18, 2022 08:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

@ahmadabdalla ahmadabdalla Awaiting requested review from ahmadabdalla

@eriqua eriqua Awaiting requested review from eriqua

Assignees

@fblix fblix

@JPEasier JPEasier

Labels
[cat] modules category: modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix DataProtection Backup Vaults
5 participants
@JPEasier @AlexanderSehr @ahmadabdalla @eriqua @fblix