Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI environment] Update removal to support Azure Security Center module #2313

Merged
merged 6 commits into from
Nov 11, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Nov 11, 2022

Description

Remove ASC dependencies but not deployed resources under the Microsoft.Security resource provider

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Security: AzureSecurityCenter

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added documentation Improvements or additions to documentation [cat] pipelines category: pipelines [cat] testing category: testing labels Nov 11, 2022
@eriqua eriqua linked an issue Nov 11, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Nov 11, 2022

Unit Test Results

  1 files  ±0    1 suites  ±0   30s ⏱️ +5s
55 tests +1  52 ✔️  - 2  3 💤 +3  0 ±0 
55 runs   - 1  52 ✔️  - 4  3 💤 +3  0 ±0 

Results for commit df4ce32. ± Comparison against base commit 2d08718.

This pull request removes 54 and adds 55 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.SignalRService/webPubSub] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.SignalRService/webPubSub] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.SignalRService/webPubSub] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.SignalRService/webPubSub] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.SignalRService/webPubSub] used resource type [webPubSub] should use one of the recent API version(s). Currently using [2021-10-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.SignalRService/webPubSub] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.SignalRService/webPubSub] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.SignalRService/webPubSub] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.SignalRService/webPubSub] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.SignalRService/webPubSub] CUA ID deployment should be present in the template
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Security/azureSecurityCenter] used resource type [autoProvisioningSettings] should use one of the recent API version(s). Currently using [2017-08-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Security/azureSecurityCenter] used resource type [deviceSecurityGroups] should use one of the recent API version(s). Currently using [2019-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Security/azureSecurityCenter] used resource type [iotSecuritySolutions] should use one of the recent API version(s). Currently using [2019-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Security/azureSecurityCenter] used resource type [#s] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Security/azureSecurityCenter] used resource type [securityContacts] should use one of the recent API version(s). Currently using [2017-08-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Security/azureSecurityCenter] used resource type [workspaceSettings] should use one of the recent API version(s). Currently using [2017-08-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Security/azureSecurityCenter] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Security/azureSecurityCenter] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Security/azureSecurityCenter] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Security/azureSecurityCenter] All required parameters in template file (deploy.json) should exist in parameters files
…

♻️ This comment has been updated with latest results.

@eriqua eriqua marked this pull request as ready for review November 11, 2022 16:34
@eriqua eriqua requested a review from a team as a code owner November 11, 2022 16:34
@eriqua eriqua merged commit 4a9f325 into main Nov 11, 2022
@eriqua eriqua deleted the users/eriqua/2281-asc-removal branch November 11, 2022 23:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[cat] pipelines category: pipelines [cat] testing category: testing documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add removal to Azure Security Center module
2 participants