Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fixes] Fixed incorrect child module references #2357

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 22, 2022

Description

  • Fixed incorrect child module references

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
EventHub: Namespaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner November 22, 2022 20:44
@AlexanderSehr AlexanderSehr self-assigned this Nov 22, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules bug Something isn't working labels Nov 22, 2022
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 22, 2022 20:45
@github-actions
Copy link

Test Results

    1 files  ±    0      1 suites  ±0   2m 1s ⏱️ + 1m 56s
281 tests +231  276 ✔️ +227  5 💤 +4  0 ±0 
298 runs  +246  291 ✔️ +242  7 💤 +4  0 ±0 

Results for commit a1ce01c. ± Comparison against base commit 16f690f.

This pull request removes 50 and adds 281 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.ApiManagement/service] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.ApiManagement/service] folder should contain one or more *parameters.json files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.ApiManagement/service/apiVersionSets] Module should contain a [deploy.json/deploy.bicep] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.ApiManagement/service/apiVersionSets] Module should contain a [readme.md] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.ApiManagement/service/apiVersionSets] Module should contain a [version.json] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.ApiManagement/service/apis/policies] Module should contain a [deploy.json/deploy.bicep] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.ApiManagement/service/apis/policies] Module should contain a [readme.md] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.ApiManagement/service/apis/policies] Module should contain a [version.json] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.ApiManagement/service/apis] Module should contain a [deploy.json/deploy.bicep] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.ApiManagement/service/apis] Module should contain a [readme.md] file
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/authorizationRules] used resource type [namespaces/authorizationRules] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/disasterRecoveryConfigs] used resource type [namespaces/disasterRecoveryConfigs] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventHubs/authorizationRules] used resource type [namespaces/eventhubs/authorizationRules] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventHubs/consumerGroups] used resource type [namespaces/eventhubs/consumergroups] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventHubs] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventHubs] used resource type [namespaces/eventhubs/authorizationRules] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventHubs] used resource type [namespaces/eventhubs/consumergroups] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventHubs] used resource type [namespaces/eventhubs] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventHubs] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/networkRuleSets] used resource type [namespaces/networkRuleSets] should use one of the recent API version(s). Currently using [2021-11-01]
…
This pull request removes 1 skipped test and adds 5 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.ApiManagement/service] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventHub/namespaces/authorizationRules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventHub/namespaces/disasterRecoveryConfigs] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventHub/namespaces/eventHubs/authorizationRules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventHub/namespaces/eventHubs/consumerGroups] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.EventHub/namespaces] *parameters.json files in the .test folder should be valid json

Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit d28cadd into main Nov 22, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/moduleRefFix branch November 22, 2022 21:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants