Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI Environment] Remove original test approach from test template & update telemetry to work with new dependency approach #2374

Merged
merged 29 commits into from
Nov 28, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 27, 2022

Description

  • Remove original test approach from pipeline templates
  • Update telemetry to work with new dependency approach
    • Slightly adjust the description

Note: The code for this PR was generated using the updated version of the ConvertTo-ARMTemplate utility in PR #2375

Note: Tested the ARM version via branch users/alsehr/2332_pipelineCleanup_ARM3 as it also required a refresh of all ReadMEs we would not want to merge into main

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline Bicep
AnalysisServices: Servers
Resources: ResourceGroups
Build Status
Build Status
AnalysisServices: Servers
Resources: ResourceGroups
Build Status
Build Status

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Nov 27, 2022
@AlexanderSehr AlexanderSehr added [cat] pipelines category: pipelines [cat] github category: GitHub [cat] azure devops category: Azure DevOps labels Nov 27, 2022
@github-actions
Copy link

github-actions bot commented Nov 27, 2022

Test Results

  1 files  ±    0    1 suites  ±0   36s ⏱️ - 3m 4s
53 tests  - 376  52 ✔️  - 365  1 💤  - 11  0 ±0 
70 runs   - 373  67 ✔️  - 362  3 💤  - 11  0 ±0 

Results for commit 622e4e1. ± Comparison against base commit ebe390d.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 27, 2022 22:04
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner November 27, 2022 22:04
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 27, 2022 22:04
@AlexanderSehr AlexanderSehr added this to the Release v0.8.0 milestone Nov 27, 2022
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 59ef075 into main Nov 28, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/2332_pipelineCleanup branch November 28, 2022 09:04
@eriqua eriqua linked an issue Nov 29, 2022 that may be closed by this pull request
@eriqua eriqua removed this from the Release v0.8.0 milestone Nov 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] pipelines category: pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discuss if keeping support to parameters.json
2 participants